Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define STRICT_R_HEADERS, use M_PI and R_{Calloc,Free} #15

Merged
merged 1 commit into from
May 24, 2021

Conversation

eddelbuettel
Copy link
Contributor

Dear Manuel, dear robustlmm team,

Your CRAN package robustlmm uses Rcpp, and is affected if we add a definition of STRICT_R_HEADERS as we would like to do. Please see the discussion at RcppCore/Rcpp#1158 and the links therein for more context on this.

Here, instead of prefixing each #include <Rcpp.h> with STRICT_R_HEADERS we set it in Makevars{,.win}. The actual change that is needed is the change from PI to M_PI in one source file, and a switch to the prefix R_ for R_Calloc and R_Free in another. No other changes were made.

It would be lovely if you could apply this. There is no strong urgency: we aim to get this done over all affected packages in the space of a few months. If you apply it, would you mind dropping me a note by email or swinging by RcppCore/Rcpp#1158 to confirm?

Many thanks for your help, and I hope you continue to find Rcpp helpful. Please don't hesitate to ask if you have any questions.

@kollerma kollerma merged commit 214e95b into kollerma:master May 24, 2021
@kollerma
Copy link
Owner

Dear @eddelbuettel

Thanks for the pull request. I'm going to push a new version of robustlmm to CRAN soon.

Best,
Manuel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants