Skip to content
This repository has been archived by the owner on Nov 2, 2023. It is now read-only.

Add support for SQL query caching #51

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Add support for SQL query caching #51

wants to merge 19 commits into from

Conversation

JakobGM
Copy link
Contributor

@JakobGM JakobGM commented Dec 16, 2022

TODO

  • Rename QueryCacher to QuerySource.
  • Add documentation tutorial for using this functionality.
  • Use XDG_CACHE_HOME for default cache location.
  • Rename sql_to_arrow to query_handler.
  • Allow QuerySource.query() to execute a SQL query string directly if provided.
  • Rename QueryCache to QuerySource since caching is not necessarily involved.
  • Add support for hashing other parameter passed to the query handler (left as future TODO).
  • Add support for writing cache files to other locations, such as Google CloudStorage (left as future TODO).
  • Rename patito.QuerySource to patito.Database, move everything DuckDB-related into patito.duckdb.

@JakobGM JakobGM self-assigned this Dec 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2022

Codecov Report

Merging #51 (6dff76d) into main (164ebed) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              main       #51    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            7         9     +2     
  Lines          956      1103   +147     
  Branches       224       242    +18     
==========================================
+ Hits           956      1103   +147     
Impacted Files Coverage Δ
src/patito/duckdb.py 100.00% <ø> (ø)
src/patito/sql.py 100.00% <ø> (ø)
src/patito/validators.py 100.00% <ø> (ø)
src/patito/__init__.py 100.00% <100.00%> (ø)
src/patito/database.py 100.00% <100.00%> (ø)
src/patito/xdg.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JakobGM JakobGM force-pushed the query-caching branch 2 times, most recently from 755060e to 2da1718 Compare December 22, 2022 14:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants