Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bgm tracker showing empty due to no Chinese name #331

Closed
wants to merge 4 commits into from

Conversation

NeKoOuO
Copy link
Contributor

@NeKoOuO NeKoOuO commented Sep 1, 2024

show name if name_cn is empty

Images

Before After
Screenshot_2024-09-02-12-57-57-546_app.komikku.beta-edit.jpg Screenshot_2024-09-02-13-01-06-719_app.komikku.debug-edit.jpg

@NeKoOuO NeKoOuO changed the title show name if name_cn is empty Fix bgm tracker showing empty due to no Chinese name Sep 1, 2024
@NeKoOuO NeKoOuO marked this pull request as ready for review September 2, 2024 04:12
@NeKoOuO
Copy link
Contributor Author

NeKoOuO commented Sep 2, 2024

Oh wait there's some big change upstream, so I think I'll wait until they merge it
mihonapp/mihon#1103

@NeKoOuO NeKoOuO marked this pull request as draft September 2, 2024 08:01
@NeKoOuO NeKoOuO closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant