Implement orientation feature #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelnietoa
requested changes
Apr 3, 2024
There was a problem hiding this comment.
@MarioRodriguezS well done! Some comments were added.
Don't forget to update demo.gif shown in the README file with the revamped UI 👌🏻
MarioRodriguezS
force-pushed
the
implement-orientation-feature
branch
from
f0d7ac6 to
9ee69b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #135
This pull request implements the orientation feature to editorjs-inline-image, the user is able to select a specific orientation and change the search result. The request to Unsplash is built as in the respective documentation. Also, the tests were updated and implemented.
Evidence
Screen.Recording.2024-04-03.at.3.21.29.PM.mov