Remove more unused interface classes #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both interfaces had exactly one instanciation each making them unnecessary.
The two implementing classes are so different, that a common interface just leads to a lot of dead code in functions that are never called.
lonvia
force-pushed
the
remove-unused-interfaces
branch
from
5a719bf
to
17da704
Compare
The interface they were named after no longer exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Elastic*Searcher interfaces each have exactly one implementation and one place where they are used. As it is unlikely that we provide alternative implementations in the future, the interfaces might as well be removed.
One of the two implementations of the TagFilterQueryBuilder interface has just had noops for most of the functions. Removing the interface removes a lot of dead code.