Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dependencies #188

Merged
merged 7 commits into from
Apr 14, 2023
Merged

Update Dependencies #188

merged 7 commits into from
Apr 14, 2023

Conversation

Bathtor
Copy link
Contributor

@Bathtor Bathtor commented Apr 14, 2023 •
edited
Loading

Please make sure these boxes are checked, before submitting a new PR.

  • You ran rustfmt on the code base before submitting (on latest nightly with rustfmt support)
  • [] You reference which issue is being closed in the PR text (if applicable)

Other Changes

  • Updated all dependencies to their latest versions (at least in core)
  • Updated to match new clippy rules on latest rust nightly and updated the CI workflow
  • Bumped version to 0.11.1 since the uuid dependency change is public facing (one could argue this is a breaking change, but that seems excessive to me).
  • Removed the codecov workflow since it hasn't run correctly in a long time. ISTR it relied on an on-prem server that clearly isn't handling these requests anymore.

@Bathtor Bathtor requested a review from adamhass April 14, 2023 06:09
adamhass
adamhass approved these changes Apr 14, 2023
View reviewed changes
Copy link
Collaborator

@adamhass adamhass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice job

@Bathtor Bathtor merged commit 71a1456 into kompics:master Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamhass adamhass adamhass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bathtor @adamhass