Skip to content

Commit

Permalink
Eliminate panics (#459)
Browse files Browse the repository at this point in the history
- Now, it is only(ideally) the config package that panics at startup if one or more options is misconfigured.
  The idea is that `ong` should return those errors upward rather than panic. If it has to panic, it should ideally do so only at one place; configuration.
- There are still some panics in `config/cert.go`. But those are only used when someone is using the `config.DevOpts`. We could remove them by using something like #277, #282
  • Loading branch information
komuw authored Jun 18, 2024
1 parent 1c1d46e commit 847e9b2
Show file tree
Hide file tree
Showing 22 changed files with 955 additions and 802 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ Most recent version is listed first.

# v0.1.2
- ong/middleware: Fix a number of CORS issues: https://github.com/komuw/ong/pull/442
- ong/middleware: Eliminate panics: https://github.com/komuw/ong/pull/459

# v0.1.1
- ong/middleware: do not show hint: https://github.com/komuw/ong/pull/457
Expand Down
Loading

0 comments on commit 847e9b2

Please sign in to comment.