Add **kwargs to all legacy provider classes, pass to super().__init__ #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 28, 2020 12:53
This allows some of the new facilities that are setup through keyword args through the drivers to operate in legacy (not alias, needs other changes).
…providers.__init__.py). And fix all those references in cli.py and dns_providers/tests/* Update README example code.
Codecov Report
@@ Coverage Diff @@
## master #189 +/- ##
=======================================
Coverage 87.46% 87.46%
=======================================
Files 18 18
Lines 1133 1133
=======================================
Hits 991 991
Misses 142 142
Continue to review full report at Codecov.
|
|
...playing little games, like not looking at it for a while, then looking... to see if I still liked it. I did. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows some of the new facilities that are setup through keyword args
through the drivers to operate in legacy (not alias, needs other changes).