Merge pull request #31 from riverson98/externaldevice

Externaldevice
konduto · Jan 10, 2023 · 3928eee · 3928eee
2 parents fad9aa8 + 552ee33
commit 3928eee
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 14 deletions.
diff --git a/README.md b/README.md
@@ -612,6 +612,21 @@ taking place which can be declared within this `tenant` node.
 | name              | _(optional)_ Platform name.                                           |
 | created_at        | _(optional)_ Platform creation date, in YYYY-MM-DD format (ISO 8601). |
 
+
+#### External Device
+| Parameter    | Description                                        |
+|--------------|----------------------------------------------------|
+| fingerprint  | _(optional)_ Browser identification.               |
+| provider     | _(optional)_ supplier type ex: `VTEX`              |   
+| category     | _(optional)_ device type ex: `mobile`, `desktop`.  |
+| model        | _(optional)_ device model ex: `iphone 8`, `S10`.   |
+| platform     | _(optional)_ Type of device by the customer.       |
+| manufacturer | _(optional)_ manufacturer type ex: `samsung`.      |
+| os           | _(optional)_ operational system ex: `android 11`.  |
+| browser      | _(optional)_ Customer browser ex: `chrome`.        |
+| language     | _(optional)_ local language ex: `pt-br`.           |
+
+
 ## Sending an order for analysis.
 
 After creating the order, sending it to Konduto's analysis is very simple.

diff --git a/src/main/java/com/konduto/sdk/models/KondutoExternalDevice.java b/src/main/java/com/konduto/sdk/models/KondutoExternalDevice.java
@@ -8,8 +8,6 @@
  *
  */
 public class KondutoExternalDevice extends KondutoModel {
-    // it is missing to create a field in the userId base to accept information
-    private String userId;
     private String fingerprint;
     private String provider;
     private String category;
@@ -31,7 +29,6 @@ public boolean equals(Object o) {
 
         KondutoExternalDevice that = (KondutoExternalDevice) o;
 
-        if (userId != null ? !userId.equals(that.userId) : that.userId != null) return false;
         if (provider != null ? !provider.equals(that.provider) : that.provider != null) return false;
         if (category != null ? !category.equals(that.category) : that.category != null) return false;
         if (model != null ? !model.equals(that.model) : that.model != null) return false;
@@ -52,14 +49,6 @@ public int hashCode() {
 
     /* Getters and Setters */
 
-    public String getUserId() {
-        return userId;
-    }
-
-    public void setUserId(String userId) {
-        this.userId = userId;
-    }
-
     public String getFingerprint() {
         return fingerprint;
     }

diff --git a/src/main/resources/konduto.properties b/src/main/resources/konduto.properties
@@ -1 +1 @@
-version = 2.17.1
+version = 2.17.3
diff --git a/src/test/java/com/konduto/sdk/factories/KondutoExternalDeviceFactory.java b/src/test/java/com/konduto/sdk/factories/KondutoExternalDeviceFactory.java
@@ -5,7 +5,6 @@
 public class KondutoExternalDeviceFactory {
     public static KondutoExternalDevice getExternalDevice(){
         KondutoExternalDevice externalDevice = new KondutoExternalDevice();
-        externalDevice.setUserId("anyID");
         externalDevice.setBrowser("Chrome");
         externalDevice.setProvider("SO");
         externalDevice.setCategory("Mobile");

diff --git a/src/test/resources/external_device.json b/src/test/resources/external_device.json
@@ -1,5 +1,4 @@
 {
-  "user_id": "anyID",
   "fingerprint": "e4f2c690951038a8f77aa583847",
   "provider": "SO",
   "category": "Mobile",