Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix yamllint #770

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Fix yamllint #770

merged 2 commits into from
Jan 30, 2024

Conversation

lcarva
Copy link
Contributor

@lcarva lcarva commented Jan 30, 2024 

Ignore files without spec in yamllint

This commit modifies the `ensure-params-not-in-script` step of the
yaml-lint task to not emit an error when processing YAML files that do
not contain a `.spec` attribute.

The functionality is unchanged. The only change is that `yq` quits early
instead of failing.

Fix yaml lint violation on tkn-bundle task

The task was merged at the same time as the yaml lint checks were
enabled.

@lcarva
Ignore files without spec in yamllint
b3fbf02 
This commit modifies the `ensure-params-not-in-script` step of the
yaml-lint task to not emit an error when processing YAML files that do
not contain a `.spec` attribute.

The functionality is unchanged. The only change is that `yq` quits early
instead of failing.

Signed-off-by: Luiz Carvalho <lucarval@redhat.com>
@lcarva
Fix yaml lint violation on tkn-bundle task
61a4f96 
The task was merged at the same time as the yaml lint checks were
enabled.

Signed-off-by: Luiz Carvalho <lucarval@redhat.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@lcarva lcarva mentioned this pull request Jan 30, 2024
Merged
@lcarva lcarva merged commit 970ca0e into konflux-ci:main Jan 30, 2024
7 checks passed
@lcarva lcarva deleted the fix-yamllint branch January 30, 2024 22:08
@rh-tap-build-team rh-tap-build-team bot mentioned this pull request Jan 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joejstuart joejstuart joejstuart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lcarva @joejstuart