Skip to content

Commit

Permalink
fix(STONEINTG-897): don't require chains for failed build PLRs
Browse files Browse the repository at this point in the history
* It's not guaranteed that a failed build pipelineRun
  will be processed by Tekton chains
* The integration service still needs to process
  those pipelineRuns in order to remove their finalizers

Signed-off-by: dirgim <kpavic@redhat.com>

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED
  • Loading branch information
dirgim committed Sep 13, 2024
1 parent f08de4f commit 7173ad8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tekton/predicates.go
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ func BuildPipelineRunFailedPredicate() predicate.Predicate {
},
UpdateFunc: func(e event.UpdateEvent) bool {
return IsBuildPipelineRun(e.ObjectNew) &&
isChainsDoneWithPipelineRun(e.ObjectNew) &&
helpers.HasPipelineRunFinished(e.ObjectNew) &&
!helpers.HasPipelineRunSucceeded(e.ObjectNew)
},
}
Expand Down

0 comments on commit 7173ad8

Please sign in to comment.