Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(go): bump k8s.io/client-go from 0.26.1 to 0.27.4 #248

Closed
wants to merge 1 commit into from
Closed

chore(go): bump k8s.io/client-go from 0.26.1 to 0.27.4 #248

wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 20, 2023 •
edited
Loading

Bumps k8s.io/client-go from 0.26.1 to 0.27.4.

Commits
  • c04e419 Update dependencies to v0.27.4 tag
  • 860d25f Merge pull request #118969champtar/automated-cherry-pick-of-#117791
  • 8d8e2bc Merge pull request #119086neolit123/automated-cherry-pick-of-#118150
  • af4a748 call ./hack/update-vendor.sh
  • 22da8a5 Merge pull request #118553 from puerco/bump-1.27-go1.20.5
  • 81d8c78 update-vendor: update vendored go.sums
  • d96d0d8 update serial number to a valid non-zero number in ca certificate
  • 015caa2 Merge pull request #117708Jefftree/automated-cherry-pick-of-#117705
  • fb5347d Update kube-openapi to fix race
  • 353c489 Merge pull request #117685ardaguclu/automated-cherry-pick-of-#117495
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jul 20, 2023
@dependabot dependabot bot mentioned this pull request Jul 20, 2023
Closed
@openshift-ci
Copy link

openshift-ci bot commented Jul 20, 2023

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a redhat-appstudio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hongweiliu17
Copy link
Contributor

/ok-to-test

@hongweiliu17
Copy link
Contributor

hongweiliu17 commented Jul 24, 2023 •
edited
Loading

The issue as below met in check-source is reported in operator-framework/operator-sdk#6396

Error: /github/home/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.5/pkg/cache/multi_namespace_cache.go:308:9: cannot use handles (variable of type map[string]"k8s.io/client-go/tools/cache".ResourceEventHandlerRegistration) as type "k8s.io/client-go/tools/cache".ResourceEventHandlerRegistration in return statement:
	map[string]"k8s.io/client-go/tools/cache".ResourceEventHandlerRegistration does not implement "k8s.io/client-go/tools/cache".ResourceEventHandlerRegistration (missing HasSynced method)

Here is a suggestion solution for it.

@dependabot dependabot bot force-pushed the dependabot/go_modules/k8s.io/client-go-0.27.4 branch from 88a5915 to dbdd624 Compare July 24, 2023 08:26
@dependabot dependabot bot force-pushed the dependabot/go_modules/k8s.io/client-go-0.27.4 branch 2 times, most recently from cf809ed to 501bbdf Compare August 2, 2023 01:55
@dependabot
chore(go): bump k8s.io/client-go from 0.26.1 to 0.27.4
57046a6 
Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.26.1 to 0.27.4.
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.26.1...v0.27.4)

---
updated-dependencies:
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/k8s.io/client-go-0.27.4 branch from 501bbdf to 57046a6 Compare August 8, 2023 08:51
@jsztuka
Copy link
Contributor

jsztuka commented Aug 10, 2023

/retest

@jsztuka
Copy link
Contributor

jsztuka commented Aug 10, 2023

Looks like breaking change, at least according to pull request. Can't tell if any tweaking is required from our side.

@openshift-ci
Copy link

openshift-ci bot commented Aug 10, 2023

@dependabot[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration-service-e2e 57046a6 link true /test integration-service-e2e
ci/prow/images 57046a6 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dirgim
Copy link
Collaborator

dirgim commented Aug 16, 2023

This PR depends on STONEINTG-529 getting resolved.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 16, 2023

Superseded by #279.

@dependabot dependabot bot closed this Aug 16, 2023
@dependabot dependabot bot deleted the dependabot/go_modules/k8s.io/client-go-0.27.4 branch August 16, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dheerajodha dheerajodha Awaiting requested review from dheerajodha dheerajodha is a code owner

@dirgim dirgim Awaiting requested review from dirgim dirgim is a code owner

@hongweiliu17 hongweiliu17 Awaiting requested review from hongweiliu17 hongweiliu17 is a code owner

@jinqi7 jinqi7 Awaiting requested review from jinqi7

@Josh-Everett Josh-Everett Awaiting requested review from Josh-Everett Josh-Everett is a code owner

@jsztuka jsztuka Awaiting requested review from jsztuka jsztuka is a code owner

@MartinBasti MartinBasti Awaiting requested review from MartinBasti

@sonam1412 sonam1412 Awaiting requested review from sonam1412 sonam1412 is a code owner

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hongweiliu17 @jsztuka @dirgim