Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(STONEINTG-523): enum for integration test status #283

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

MartinBasti
Copy link
Collaborator

@MartinBasti MartinBasti commented Aug 23, 2023

This commit provides base data structure for the keeping status of tests.

Type supports string and JSON interfaces to convert between numeric and textual representation.

Maintainers will complete the following section

  • Commit messages are descriptive enough (hints)
  • Code coverage from testing does not decrease and new code is covered
  • Controllers diagrams are updated when PR changes controllers code (if applicable)

gitops/snapshot.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: +2.48% 🎉

Comparison is base (c77bce0) 67.61% compared to head (17bfc73) 70.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #283      +/-   ##
==========================================
+ Coverage   67.61%   70.10%   +2.48%     
==========================================
  Files          38       38              
  Lines        3495     3495              
==========================================
+ Hits         2363     2450      +87     
+ Misses        890      800      -90     
- Partials      242      245       +3     
Files Changed Coverage Δ
gitops/snapshot.go 78.77% <ø> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gitops/snapshot.go Outdated Show resolved Hide resolved
@MartinBasti
Copy link
Collaborator Author

Coverage is low because of generated code, can I wave it?

@dirgim
Copy link
Collaborator

dirgim commented Aug 23, 2023

Coverage is low because of generated code, can I wave it?

I think it would be best to add the generated file to the ignore list in codecov.yml.

This commit provides base data structure for the keeping status of
tests.

Type supports string and JSON interfaces to convert between numeric and
textual representation.

Signed-off-by: Martin Basti <mbasti@redhat.com>
Copy link
Contributor

@hongweiliu17 hongweiliu17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@dirgim dirgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MartinBasti MartinBasti merged commit 6b140fa into konflux-ci:main Aug 24, 2023
11 checks passed
@MartinBasti MartinBasti deleted the test_reports_base branch August 24, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants