fix(STONEINTG-641): use snapshot for SEB components directly #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirgim
changed the title
dirgim
requested review from
jsztuka,
hongweiliu17,
14rcole,
dheerajodha,
Josh-Everett and
jencull
|
I've confirmed that the approach in this PR is correct, marking this PR as ready for review. |
* Refactor NewBindingComponents to take components directly from the Snapshot and convert them into bindingComponents by referencing them by the resource metadata.name instead of spec.componentName. * This removes the need for the extra step of fetching Components from the cluster * Remove the GetAllSnapshotComponents function altogether as it is unused after the above changes * Remove the now unused components parameter from functions which were creating/updating SEBs Signed-off-by: dirgim <kpavic@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
metadata.nameinstead ofspec.componentName.Maintainers will complete the following section