-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(STONEINTG-999): report test status for group snapshot #860
Conversation
e3bf184
to
1f23888
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #860 +/- ##
=======================================
Coverage ? 69.24%
=======================================
Files ? 43
Lines ? 4552
Branches ? 0
=======================================
Hits ? 3152
Misses ? 1062
Partials ? 338 ☔ View full report in Codecov by Sentry. |
1f23888
to
d0ab8d5
Compare
The new text template with component snapshot info for group snapshot can generate content like below:
The group snapshot is generated for the component snasphots as below:
Footnotes |
The feature code is ready for review. I will work on the unit test part next. |
e1579b0
to
363b387
Compare
363b387
to
338c48f
Compare
338c48f
to
dcded64
Compare
* update status report template to generate text including group snapshot info Signed-off-by: Hongwei Liu <hongliu@redhat.com>
dcded64
to
9c5ec09
Compare
ca8daa1
to
0755aca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Inspirational stuff as always Hongwei!
0755aca
to
5170aad
Compare
Test on my personal cluster and it can create checkRun successfully, refer to https://github.com/hongweiliu17/devfile-sample-go-basic-1772/pull/1/checks?check_run_id=30507639589 and https://github.com/hongweiliu17/devfile-sample-java-springboot-basic-1772/pull/1/checks?check_run_id=30507642618 |
* Update EnsureSnapshotTestStatusReportedToGitProvider to support group snapshot Signed-off-by: Hongwei Liu <hongliu@redhat.com>
5170aad
to
0d83137
Compare
New changes are detected. LGTM label has been removed. |
Found one bug in when SetLastUpdateTime, because this is a loop, so we may need to also include the |
/retest |
1 similar comment
/retest |
/retest-required |
/retest |
4 similar comments
/retest |
/retest |
/retest |
/retest |
Signed-off-by: Hongwei Liu hongliu@redhat.com
Maintainers will complete the following section