Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove test-metadata test-event-type and use integration service contexts #881

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

flacatus
Copy link
Contributor

Maintainers will complete the following section

Copy link
Collaborator

@dirgim dirgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@8822187). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #881   +/-   ##
=======================================
  Coverage        ?   69.22%           
=======================================
  Files           ?       43           
  Lines           ?     4455           
  Branches        ?        0           
=======================================
  Hits            ?     3084           
  Misses          ?     1048           
  Partials        ?      323           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flacatus flacatus changed the title feat: Remove test-metadata test event type and use integration service contexts feat: Remove test-metadata test-event-type and use integration service contexts Sep 18, 2024
@flacatus
Copy link
Contributor Author

/retest

Copy link
Contributor

@hongweiliu17 hongweiliu17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flacatus flacatus merged commit abb5a63 into konflux-ci:main Sep 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants