Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(KFLUXUI-198): component relationship remove button #45

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

testcara
Copy link
Contributor

@testcara testcara commented Dec 3, 2024

Backports KFLUXBUGS-1197

@sahil143
Copy link
Collaborator

sahil143 commented Dec 3, 2024

/ok-to-test

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 79.88%. Comparing base (850c442) to head (094af03).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
src/components/ComponentRelation/utils.ts 10.00% 9 Missing ⚠️
...nents/ComponentRelation/ComponentRelationModal.tsx 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
+ Coverage   79.61%   79.88%   +0.27%     
==========================================
  Files         564      568       +4     
  Lines       20991    21270     +279     
  Branches     5200     5275      +75     
==========================================
+ Hits        16712    16992     +280     
+ Misses       4254     4253       -1     
  Partials       25       25              
Flag Coverage Δ
unittests 79.88% <50.00%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@testcara
Copy link
Contributor Author

testcara commented Dec 3, 2024

/retest

@sahil143
Copy link
Collaborator

sahil143 commented Dec 3, 2024

/ok-to-test

@testcara
Copy link
Contributor Author

testcara commented Dec 3, 2024

/ok-to-test

1 similar comment
@testcara
Copy link
Contributor Author

testcara commented Dec 3, 2024

/ok-to-test

@testcara
Copy link
Contributor Author

testcara commented Dec 4, 2024

After adding more cases, it seems the project coverage rises but the patch coverage keeps stale.
Currently, the project coverage is higher than the base project coverage.

When I check the patch coverage report, I feel it does not make sense.

See the screenshot below:
Screenshot 2024-12-04 at 15 19 19

The marked missing hit lines have been covered during tests and more, I do not think counting empty lines helps.
@sahil143 , is it possible to ignore the patch coverage for this patch? or do you have any clues about adding extra testings to those lines?

@sahil143 sahil143 merged commit adc7e77 into konflux-ci:main Dec 9, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants