feat(KFLUXUI-36): updated wordings in customizepipelines component fo… #96
Conversation
…r install gitHub application
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
==========================================
+ Coverage 80.08% 80.10% +0.02%
==========================================
Files 544 544
Lines 21181 21164 -17
Branches 5064 5327 +263
==========================================
- Hits 16962 16953 -9
+ Misses 4195 4186 -9
- Partials 24 25 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
/test |
| const gitlabURL = | ||
| 'https://konflux-ci.dev/docs/how-tos/configuring/creating-secrets/#creating-source-control-secrets'; |
There was a problem hiding this comment.
You can use the link in component, no need to create a variable.
There was a problem hiding this comment.
Also in some ticket we changed gitlab and github naming to git.
There was a problem hiding this comment.
Updated the changes.
…lt pipeline button
|
/test |
| @@ -387,34 +296,43 @@ const CustomizePipeline: React.FC<React.PropsWithChildren<Props>> = ({ | |||
| <> | |||
| <TextContent | |||
| className="pf-v5-u-text-align-center pf-v5-u-pt-lg" | |||
| style={{ visibility: allLoading ? 'hidden' : undefined }} | |||
| style={{ visibility: allLoading ? 'hidden' : undefined, textAlign: 'center' }} | |||
There was a problem hiding this comment.
pf-v5-u-text-align-center should align the text to the center?
There was a problem hiding this comment.
Well this classname is not available now as part of v5 now
There was a problem hiding this comment.
if it's not available please remove it's usage
| </Text> | ||
| <Text component={TextVariants.p}> | ||
| <ExternalLink | ||
| href={githubAppURL} | ||
| style={{ paddingLeft: 'var(--pf-v5-global--spacer--2xl)' }} | ||
| href={'https://pipelinesascode.com/docs/install/github_apps/#manual-setup'} |
There was a problem hiding this comment.
this should be a link to install GitHub app?!
There was a problem hiding this comment.
Link is added as per https://issues.redhat.com/browse/KFLUXUI-36. Please let me know if any change required
There was a problem hiding this comment.
please change this to GitHub application url
| repository. With custom build pipelines, commits to your main branch and pull requests | ||
| will automatically rebuild. You can always roll back to default. | ||
| </Text> | ||
| <Text component={TextVariants.h2}>{'Manage build pipeline'}</Text> |
There was a problem hiding this comment.
| <Text component={TextVariants.h2}>{'Manage build pipeline'}</Text> | |
| <Text component={TextVariants.h2}>Manage build {pluralize(components.length, 'pipeline')}</Text> |
|
/test |
Fixes
https://issues.redhat.com/browse/KFLUXUI-36
Description
Type of change
Screen shots / Gifs for design review
How to test or reproduce?
Browser conformance: