chore: reconcile on project and template changes #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifireball
approved these changes
Nov 19, 2024
|
please rebase |
By having the controller watch project and template changes, dev streams will be reconciled when those resources are created or modified. With that in place, resources can now be created and modified in any order, and resources will be generated per the latest changes and owner ref will be updated between dev stream and project. Signed-off-by: Yftach Herzog <yherzog@redhat.com>
yftacherzog
force-pushed
the
watch-templates
branch
from
5f352b5 to
f6775ab
Compare
yftacherzog
added a commit
to yftacherzog/infra-deployments
that referenced
this pull request
Nov 19, 2024
This introduces into production a change in which the controller watches also over the project and template resources. konflux-ci/project-controller#124 Signed-off-by: Yftach Herzog <yherzog@redhat.com>
openshift-merge-bot bot
pushed a commit
to redhat-appstudio/infra-deployments
that referenced
this pull request
Nov 19, 2024
This introduces into production a change in which the controller watches also over the project and template resources. konflux-ci/project-controller#124 Signed-off-by: Yftach Herzog <yherzog@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By having the controller watch project and template changes, dev streams will be reconciled when those resources are created or modified.
With that in place, resources can now be created and modified in any order, and resources will be generated per the latest changes and owner ref will be updated between dev stream and project.