fix(RHTAPWATCH-819): Resolve EC label errors #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifireball
requested changes
Mar 19, 2024
Dockerfile
Outdated
| LABEL description="Konflux Project Controller" | ||
| LABEL com.redhat.component="Konflux Project Controller" | ||
| LABEL io.k8s.description="Konflux Project Controller" | ||
| LABEL io.k8s.display-name="o11y-project-controller" |
There was a problem hiding this comment.
This has nothing to do with o11y. Please use "konflux" here.
ifireball
requested changes
Mar 19, 2024
| @@ -1,5 +1,5 @@ | |||
| # Build the manager binary | |||
| FROM golang:1.21 AS builder | |||
| FROM registry.access.redhat.com/ubi9/go-toolset:1.20.10-2 AS builder | |||
There was a problem hiding this comment.
We don't have redhat Go 1.21.x image yet. The latest one 1.20.10-3.
|
Please rebase to see if the latest code builds |
|
/retest |
Add missing labels which should be present and update images used in Dockerfile for the integration tests to pass. Signed-off-by: Homaja Marisetty <hmariset@redhat.com> Signed-off-by: Barak Korren <bkorren@redhat.com>
ifireball
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing labels which should be present in Dockerfile for the integration tests to pass.