fix: run create-advisory late in the rh-advisories pipeline #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happybhati
previously approved these changes
Oct 30, 2024
johnbieren
requested changes
Oct 30, 2024
mmalina
force-pushed
the
advisory-order
branch
2 times, most recently
from
90b21d6
to
4a84e85
Compare
johnbieren
approved these changes
Oct 30, 2024
mmalina
force-pushed
the
advisory-order
branch
from
4a84e85
to
298a3e4
Compare
|
New changes are detected. LGTM label has been removed. |
Task `create-advisory` would run after `publish-pyxis-repository` which would ensure it runs late in the pipeline. But with the changes in 1.5.0, `publish-pyxis-repository` runs much earlier now. So make `create-advisory` run after `push-rpm-data-to-pyxis` which is what `publish-pyxis-repository` ran after originally. Also add a few more `runAfter` for create-advisory so it's really running as late as possible. Also, add a few more explicit `runAfter` items to some other tasks to make order more explicit. Signed-off-by: Martin Malina <mmalina@redhat.com>
mmalina
force-pushed
the
advisory-order
branch
from
298a3e4
to
dcdddd2
Compare
Scott's test was successful. He did both runs - one with rh-sign-image-cosign and one when it was skipped. Both worked. |
|
/retest |
|
@mmalina: The following test has Failed, say /retest to rerun failed tests.
Inspecting Test ArtifactsTo inspect your test artifacts, follow these steps:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/konflux-team/release-service-catalog:konflux-e2e-tests-catalog-tdxqw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
create-advisorywould run afterpublish-pyxis-repositorywhich would ensure it runs late in the pipeline. But with the changes in 1.5.0,publish-pyxis-repositoryruns much earlier now.So make
create-advisoryrun afterpush-rpm-data-to-pyxiswhich is whatpublish-pyxis-repositoryran after originally.