fix: contributing doc to say task tests are required #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbieren
approved these changes
Nov 4, 2024
This recently came up in a PR: konflux-ci#656 We definitely do require tests for all new tasks. For existing tasks, we mostly do as well, but there are still three tasks without tests: - base64-encode-checksum - create-internal-request - prepare-validation Signed-off-by: Martin Malina <mmalina@redhat.com>
mmalina
force-pushed
the
task-tests-doc
branch
from
ca0d2fd
to
4fe80ca
Compare
|
New changes are detected. LGTM label has been removed. |
|
Doc change, e2e is irrelevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This recently came up in a PR:
#656
We definitely do require tests for all new tasks. For existing tasks, we mostly do as well, but there are still three tasks without tests: