Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump release-service-utils in push-snapshot #671

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

lcarva
Copy link
Contributor

@lcarva lcarva commented Nov 5, 2024

The new image brings a new version of the get-image-architecture script which can properly handle a Tekton bundle. This update was previously done to the apply-mapping Task, but the push-snapshot Task also relies on it.

Ref: KFLUXBUGS-1741

@lcarva lcarva requested a review from a team as a code owner November 5, 2024 17:59
Copy link
Contributor

@happybhati happybhati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lcarva , May I ask for a task version bump and update in README? You can take an example from this recent PR

The new image brings a new version of the get-image-architecture script
which can properly handle a Tekton bundle. This update was previously
done to the apply-mapping Task, but the push-snapshot Task also relies
on it.

Ref: KFLUXBUGS-1741

Signed-off-by: Luiz Carvalho <lucarval@redhat.com>
@lcarva
Copy link
Contributor Author

lcarva commented Nov 5, 2024

Hey @lcarva , May I ask for a task version bump and update in README? You can take an example from this recent PR

Done! Thanks for the prompt review.

@johnbieren
Copy link
Collaborator

/retest

@johnbieren
Copy link
Collaborator

/retest

@johnbieren johnbieren enabled auto-merge (squash) November 5, 2024 20:02
@konflux-ci-qe-bot
Copy link

@johnbieren: The following test has Failed, say /retest to rerun failed tests.

PipelineRun Name Status Rerun command Build Log Test Log
konflux-e2e-tests-catalog-7cffm Failed /retest View Pipeline Log View Test Logs

Inspecting Test Artifacts

To inspect your test artifacts, follow these steps:

  1. Install ORAS (see the ORAS installation guide).
  2. Download artifacts with the following commands:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/konflux-team/release-service-catalog:konflux-e2e-tests-catalog-7cffm

@lcarva
Copy link
Contributor Author

lcarva commented Nov 5, 2024

I see some of this in the e2e test failures:

"conditions": [                                                                     
135                     {                                                                               
136                         "lastTransitionTime": "2024-11-05T19:51:42Z",                               
137                         "message": "Error retrieving pipeline for pipelinerun ex-registry-managed-duah/managed-ql84k: reso    lver failed to get Pipeline : error requesting remote resource: error getting \"Git\" \"ex-registry-managed-duah/git-a11a6    8459a38cb2e02133eae67712474\": clone error: authentication required",
138                         "reason": "CouldntGetPipeline",                                             
139                         "status": "False",                                                          
140                         "type": "Succeeded"                                                         
141                     }                                                                               
142                 ],   

Is authentication really needed? If so, maybe the problem is because this PR comes from a fork making the GitHub secrets not available.

@mmalina
Copy link
Contributor

mmalina commented Nov 6, 2024

I see some of this in the e2e test failures:

"conditions": [                                                                     
135                     {                                                                               
136                         "lastTransitionTime": "2024-11-05T19:51:42Z",                               
137                         "message": "Error retrieving pipeline for pipelinerun ex-registry-managed-duah/managed-ql84k: reso    lver failed to get Pipeline : error requesting remote resource: error getting \"Git\" \"ex-registry-managed-duah/git-a11a6    8459a38cb2e02133eae67712474\": clone error: authentication required",
138                         "reason": "CouldntGetPipeline",                                             
139                         "status": "False",                                                          
140                         "type": "Succeeded"                                                         
141                     }                                                                               
142                 ],   

Is authentication really needed? If so, maybe the problem is because this PR comes from a fork making the GitHub secrets not available.

No, authentication should definitely not be required. @jinqi7 any idea what's wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants