-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi platform build with kotlin 2.0.0 #106
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
72a7ab6
multi platform build with kotlin 2.0 RC2
jillesvangurp 1e9762d
Merge remote-tracking branch 'origin/main' into kotlin-2-and-multipla…
jillesvangurp 750c9dc
update to RC3
jillesvangurp d99db7d
Merge remote-tracking branch 'origin/main' into kotlin-2-and-multipla…
jillesvangurp 862bf9f
add gradle caching to jvm and remove redundant gradle setup (gradle w…
jillesvangurp b4570c2
add back explicit jvm target
jillesvangurp cd3e63c
add comment
jillesvangurp be75972
make ktlint happy
jillesvangurp abc356d
update to 2.0.0 final
jillesvangurp 9b6ba29
Merge branch 'main' into kotlin-2-and-multiplatform
jillesvangurp 72fab26
1.8 should work fine after all
jillesvangurp c777ee0
Merge branch 'main' into kotlin-2-and-multiplatform
dhoepelman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,3 +32,6 @@ node_modules/ | |
|
||
# Secrets | ||
*.secret | ||
|
||
# created by kotlin 2.0 | ||
.kotlin |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not true?
I'm not opposed to bumping the JVM target version, but it should be 11 (LTS) instead of 10, and preferably for a good reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, my bad, I was getting some weird error earlier. It seems 1.8 works after all. I meant to update to 11 but was getting an error. I'll push the fix.