unused code

[winglian]

there are several places where this is defined

mm, nn = m*mr, n * nr

but those variables aren't ever used. Is this a signal the implementation is incorrect or can they be safely removed?

[kongds]

It can be safely removed.

The following code is used to split x into x[..., :mm] and x[..., mm:]:

mr, nr = in_f // r + 1, in_f // r
m, n = in_f - r * nr, r * mr - in_f
mm, nn = m * mr, n * nr

This ensures that we can use code like the following to reduce the dimension of x from in_f to r = mr + nr:

MoRA/peft-mora/src/peft/tuners/lora/layer.py

Lines 251 to 253 in 0ff64b1

	x_m = x_m.view(*x.shape[:-1], m, mr).sum(dim=-1)
	x_n = x_n.view(*x.shape[:-1], n, nr).sum(dim=-1)
	in_x = torch.cat([x_m, x_n ], dim=-1)