Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serde json serialization #1

Draft
wants to merge 34 commits into
base: master
Choose a base branch
from
Draft

Serde json serialization #1

wants to merge 34 commits into from

Conversation

konradjniemiec
Copy link
Owner

@konradjniemiec konradjniemiec commented Nov 2, 2021 •
edited
Loading

First round for draft review.

Still missing:

  • enums
  • maps
  • cleanup of conformance/main.rs & roundtrip/lib.rs
  • Timestamp fixes
  • Duration fixes

konradjniemiec and others added 30 commits March 23, 2021 10:41
@konradjniemiec
conformance + initial impl
1e57845
@konradjniemiec
initial try, need to get to WK
ca91e1a
@konradjniemiec
saving old work
b940867
@konradjniemiec
Merge branch 'master' into serde_json_serialization
46a5fff
@konradjniemiec
get back in working state
4a13f3c
@konradjniemiec
uh?
de960ff
@konradjniemiec
lifetime error
6270fff
@konradjniemiec
stopping point
6dd713c
@konradjniemiec
working
680f8b7
@konradjniemiec
work
6f542b6
@konradjniemiec
final check in before putting up for 1 level of review
1469062
@konradjniemiec
fmt
06c0983
@konradjniemiec
remove comment + add failed tests
a002a23
@konradjniemiec
almost ready for review
7ac0d01
@konradjniemiec
no-op
7766e33
@konradjniemiec
final changes
0d62c8c
@konradjniemiec
add maps, still haven't cleaned up some code
0dd0652
@konradjniemiec
maps working correctly
5f6c093
@konradjniemiec
updated w partial enums
372aa43
@konradjniemiec
fmt
ac9adfd
@konradjniemiec
Merge branch 'master' into serde_json_serialization
565d04a
@Projoh
Added enum visitor and enum opt visitor
9ef2b42
@konradjniemiec
cleanup + make enums work mostly
1ab98b7
@Projoh
Fixed oneof and enum unknown handling
9a54788
@konradjniemiec
review ready
34c21f4
@konradjniemiec
Merge branch 'serde_json_serialization' of github.com:konradjniemiec/…
45fb956 
…prost into serde_json_serialization
@konradjniemiec
Merge branch 'master' into serde_json_serialization
b346867
@konradjniemiec
i64/u64 serialize as string, add empty visitor
96755dd
@konradjniemiec
empty + fmt
4b5a456
@konradjniemiec
add better empty impl
db0d9a8
danburkert pushed a commit to sisudata/prost that referenced this pull request Feb 10, 2023
@YoshikiTakashima
chore: Added Kani to CI. (konradjniemiec#1) (tokio-rs#798)
b72967a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@konradjniemiec @Projoh