Send beacon #956
Merged
Send beacon #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was made by reason. There can be multiple instances of Document or Window per app, for example, when parsing XML/HTML manually (and thus using DOM to navigated detached document) or when using iframes. However, Navigator only needs single instance per browser. If you look at its methods, it becomes quite clear that it does not act in the context of a frame or a tab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @konsoletyper . This PR adds navigator.sendBeacon function. Still, when I looked at navigator class, I noticed that all its methods are static. This is very different from Window or Document, which are abstract, but are instantiated using Window.current() or HTMLDocument.current(). Is it made for a reason and is it working or it is just a mistake that happened during the refactoring?