feat: Enforce types #160
Merged
feat: Enforce types #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: move constants to central location * chore: place overrides in declaration.d.ts file for accurate ts autocomplete/definitions * chore: place utils in central location. add GithubUser,GithubUserPlan,GithubUserOrganization types. * refactor: update readiness slice to a more descriptive variable description of the state is represents. * chore: remove selectors. state selection exposed by useAppSelector. * refactor: githubApi axed. githubUser slice state houses pertinent github user info. * chore: getUser, getUserOrganization thunks made with tests to verify behavior. * chore: enforce types * refactor: update installation slice * chore: update some hooks * refactor: make controlled fields pass generic type to control for proper type inference for form values. * refactor: a button is a button * chore: more accurate description of what component actually is * chore: pull InstallationButtons into separate comp * chore: pull InstallationCard into its own component * chore: pull InstallationInfoCard into separate comp * chore: create InstallationStepContainer * chore: layout comps, odds and ends. no inherent comp styles to throw off layout * refactor: update LocalSetupForm and LocalFormFlow * refactor: update aws github forms and flow. * refactor: update aws gitlab forms and install flow * chore: add civo github readiness, setup forms and install flow * chore: add civo gitlab readiness, setup forms and install flow. * chore: remove dashboard implementation. layout change simplification. other improvements * loosely hooked up installations for existing options. installations selected and routed from installations/index * fix: have forms validate before advancing step. * chore: create NextLink comp because Link provided by next does not inherit className, id for styling. create wrapper to place link as expected with styled-components. * fix: strip and import styles from .styled files. lowercase naming for folders. replace color strings with names constants. use named exports for more readable and constant naming convention of differing style themes. * fix: pin node@16.15.1. nuke node_modules and re-install * fix: rename slices based off of pr review note. renamed getters and pieces of state accordingly. * fix: export generated hooks. add proper arg types to api mutations. slight change to handlers and types for ease of use. * fix: drop form/form flow stories. seperate/import styles. move logic from page to FormFlow component. * coerce boolean|undefined value to string for accepted input value. * adds updates to civo github --------- Co-authored-by: Jared Edwards <jared@kubefirst.com>
Selection comps
…t was? add optional gitProvider to installationSlice as well as make installType optional.
…e complexity might change/other comp reliance.
…ce the provider selection/flow has changed.
Cloud provider page
chore: add mvp terminal showing socket output
* move InstallationSelection into containers * chore: add useWebsocket hook * refactor: update TerminalLogs to take optional websocket and write formatted stream data to xterminal * fix: add small amount of flexibility with CloudProviderCard width so styles are more responsive between shift below large breakpoint. * chore: update installation pages to route through single point and render component based on gitProvider and installType.
jarededwards
approved these changes
Apr 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #144 #145 #146 #147