Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make provision forms and content responsive #456

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Conversation

D-B-Hawk
Copy link
Contributor

@D-B-Hawk D-B-Hawk commented Feb 8, 2024

Screen Recording 2024-02-08 at 9 52 15 AM(1)
Screen Recording 2024-02-08 at 9 49 52 AM(1)
Screen Recording 2024-02-08 at 9 48 06 AM(1)
Screen Recording 2024-02-08 at 9 46 37 AM(1)

@D-B-Hawk D-B-Hawk requested a review from CristhianF7 February 8, 2024 18:26
CristhianF7
CristhianF7 previously approved these changes Feb 8, 2024
Copy link
Contributor

@CristhianF7 CristhianF7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks dude 🔥

@D-B-Hawk D-B-Hawk requested a review from fharper February 8, 2024 18:36
@fharper
Copy link
Contributor

fharper commented Feb 8, 2024

I have responsive issue on the first screen, am I the only one?

CleanShot.2024-02-08.at.13.45.03.2.mp4

@fharper
Copy link
Contributor

fharper commented Feb 8, 2024

Oh sorry, you made only the forms responsive. I didn't realize while checking your screen captures, my bad.

@D-B-Hawk
Copy link
Contributor Author

D-B-Hawk commented Feb 8, 2024

Oh sorry, you made only the forms responsive right @D-B-Hawk ?

Yes. But thank you for the call out on that first page @fharper!. I shall fix that

fharper
fharper previously approved these changes Feb 8, 2024
…all. improve card styles for smaller screen sizes by allowing description to scroll once width is hindered.
@D-B-Hawk D-B-Hawk dismissed stale reviews from fharper and CristhianF7 via 22175d8 February 8, 2024 20:04
@D-B-Hawk D-B-Hawk merged commit 5a01473 into main Feb 8, 2024
1 check passed
@D-B-Hawk D-B-Hawk deleted the responsive_provision branch February 8, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants