Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Azure GitLab #454

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Add support for Azure GitLab #454

merged 1 commit into from
Nov 7, 2024

Conversation

mrsimonemms
Copy link
Contributor

@mrsimonemms mrsimonemms commented Oct 29, 2024

Description

This adds the GitLab requirements. GitLab's container registry configuration is slightly different to GitHub's and I'd missed that out.

Related Issue(s)

Fixes #459

How to test

This assumes you're running the console, API and CLI in local debug mode.

  1. Create personal keys for our Terraform service principal.
  2. Set ARM_CLIENT_ID, ARM_CLIENT_SECRET, ARM_TENANT_ID and ARM_SUBSCRIPTION_ID envvars
  3. Run your desired command in the CLI

Example CLI commands:

Azure DNS

You will need to create a DNS Zone with your desired domain registered. I have the domains registered elsewhere and setup a subdomain in Azure (eg, azure.domain.com) and then setup an NS record on my domain registrar.

Azure puts everything in resource groups, which is a logical grouping of multiple resources. You will need to provide the name of that in --dns-azure-resource-group.

go run . beta azure create \
  --alerts-email <your-email> \
  --domain-name <domain-name> \
  --git-provider gitlab \
  --gitlab-group <gitlab-group> \
  --gitops-template-branch sje/azure-gitlab \
  --dns-azure-resource-group <dns-zone-resource-group>

Cloudflare

go run . beta azure create \
  --alerts-email <your-email> \
  --domain-name <domain> \
  --git-provider gitlab \
  --gitlab-group <gitlab-group> \
  --gitops-template-branch sje/azure-gitlab \
  --cluster-name <cluster-name> \
  --dns-provider cloudflare \
  --cloud-region <region> \
  --subdomain <cloudflare-subdomain>

@mrsimonemms mrsimonemms changed the base branch from main to sje/azure October 30, 2024 09:55
@mrsimonemms mrsimonemms changed the base branch from sje/azure to main October 30, 2024 09:56
@mrsimonemms mrsimonemms changed the title Sje/azure gitlab Add support for Azure GitLab Oct 30, 2024
@mrsimonemms mrsimonemms changed the base branch from main to sje/azure October 30, 2024 10:00
@mrsimonemms mrsimonemms force-pushed the sje/azure-gitlab branch 2 times, most recently from 7b2859b to 2ab4b16 Compare October 30, 2024 10:16
@mrsimonemms mrsimonemms marked this pull request as ready for review October 30, 2024 17:15
@mrsimonemms mrsimonemms changed the base branch from sje/azure to main October 30, 2024 17:16
@mrsimonemms mrsimonemms marked this pull request as draft October 30, 2024 17:16
@mrsimonemms mrsimonemms force-pushed the sje/azure-gitlab branch 2 times, most recently from 6356d13 to c537879 Compare November 5, 2024 14:23
@jokestax
Copy link
Contributor

jokestax commented Nov 7, 2024

lgtm

@mrsimonemms mrsimonemms merged commit c335a2b into main Nov 7, 2024
2 checks passed
@mrsimonemms mrsimonemms deleted the sje/azure-gitlab branch November 7, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Gitlab
2 participants