Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k1-state push/pull is failing to pull kubefirst config from S3 bucket #218

Closed
converge opened this issue Aug 12, 2022 · 0 comments
Closed

k1-state push/pull is failing to pull kubefirst config from S3 bucket #218

converge opened this issue Aug 12, 2022 · 0 comments

Comments

@converge
Copy link
Contributor

converge commented Aug 12, 2022 •
edited
Loading

When k1-state pull is called, since last AWS update it's using viper config, that cannot exist at the time the user is trying to k1-state pull.

Solution: re-design the architecture of the command.

Acceptance criteria:

  1. there are unit tests for the feature in order to avoid break it
converge pushed a commit that referenced this issue Aug 17, 2022
fix: state pull when there is no kubefirst config file #218
d87a942 
Signed-off-by: João Vanzuita <joao@kubeshop.io>
@converge converge mentioned this issue Aug 17, 2022
Merged
converge pushed a commit that referenced this issue Aug 18, 2022
Merge pull request #248 from kubefirst/fix_218
f46925d 
fix: state pull when there is no kubefirst config file #218
6za added a commit that referenced this issue Aug 26, 2022
@6za @johndietz @pagottoo
Synch main v190 (#282)
1db70c0 
* Update config.go (#224)

* update libs versions

Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>

* check if m1 and download arm64 supported version

Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>

* Allow templates to be version controlled by tags -  #227 (#231)

* Solve #227

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Add support to fallback logic

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Add support to fallback logic

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Add support to fallback logic

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Solve #233 (#234) - Adds cli version to telemetry

Adds cli version to telemetry

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* feat: add kubefirst config auto push to the user state store bucket

Signed-off-by: João Vanzuita <joao@kubeshop.io>

* change func to return bool if liveness test fail or not

Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>

* handling the value returned by func and panic if this is false

Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>

* fix: state pull when there is no kubefirst config file #218

Signed-off-by: João Vanzuita <joao@kubeshop.io>

* chore: update logic

Signed-off-by: João Vanzuita <joao@kubeshop.io>

* docker image to run kubefirst bin inside container  (#250)

Bump to release 1.8.6

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
Co-authored-by: 6za <53096417+6za@users.noreply.github.com>

* fix: add missing cmd entry for docker compose

Signed-off-by: João Vanzuita <joao@kubeshop.io>

* feat: add docker compose for developers

Signed-off-by: João Vanzuita <joao@kubeshop.io>

* Update docker-compose.yaml

* chore: update docker compose workdir

Signed-off-by: João Vanzuita <joao@kubeshop.io>

* chore: fix typo on installation screen

Signed-off-by: João Vanzuita <joao@kubeshop.io>

* synch with main

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Fix bucket cleaning logic

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
Signed-off-by: João Vanzuita <joao@kubeshop.io>
Co-authored-by: John Dietz <john@kubefirst.com>
Co-authored-by: Thiago Pagotto <pagottoo@gmail.com>
Co-authored-by: João Vanzuita <joao@kubeshop.io>
6za added a commit that referenced this issue Aug 26, 2022
@6za @pagottoo
@johndietz @marinhojess
Candidate Version of 1.9.0 (#223)
6b40a20 
* 1st attempt of github installer

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* update bars

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Add github libs

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* update plan

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Testing a wrapper for github (#166)

* Testing a wrapper for github

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Testing a wrapper for github

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Testing a wrapper for github

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Testing a wrapper for github

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* initial try for github cmds (#171)

* initial try for github cmds

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* updates

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Add git push for github

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* update clone/detoken

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* update clone/detoken

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* 1st attempt of github installer

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>

* update bars

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>

* Add github libs

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>

* update plan

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>

* Testing a wrapper for github (#166)

* Testing a wrapper for github

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Testing a wrapper for github

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Testing a wrapper for github

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Testing a wrapper for github

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>

* initial try for github cmds (#171)

* initial try for github cmds

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* updates

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Add git push for github

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* update clone/detoken

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* update clone/detoken

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>

* wip

Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>

* wip

Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>

* wip

Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>

* clean create

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* update create

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* add checks

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* add ssh keys

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* adding argo config

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* add aws-nodes-spot flag on init cmd

Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>

* change template repo to temporary fork

Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>

* pass variable from viper to tf vars

Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>

* inform complete repo name to func

Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>

* clone repos using complete repo name

Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>

* change SPOT var from bool to string

Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>

* change var name

Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>

* rollback test to previus code

Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>

* Fix steps

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Update detoken rules

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* #210 fix

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Update lofic

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* remove debug logs

Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>

* Update handoff screen

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Cleaning commands

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* fix hardcoded repo

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* minor tweaks

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Simplify create (#226)

* Update config.go (#224)

* Simplify create

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* re-org flags code

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Update flags logic

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Update flags logic

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* update libs versions

Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>

* check if m1 and download arm64 supported version

Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>

* Allow templates to be version controlled by tags -  #227 (#231)

* Solve #227

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Add support to fallback logic

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Add support to fallback logic

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Add support to fallback logic

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Synch flags changes

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Solve #242 on gh

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* new create mode

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* update init

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Update to support init

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>
Co-authored-by: John Dietz <john@kubefirst.com>
Co-authored-by: Thiago Pagotto <pagottoo@gmail.com>

* refactor: update aws sdk library to use v2 only

Signed-off-by: João Vanzuita <joao@kubeshop.io>

* chore: remove alias for s3v2 and use s3

Signed-off-by: João Vanzuita <joao@kubeshop.io>

* Add metaphor apps (#251)

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* fix: go test warnings

Signed-off-by: João Vanzuita <joao@kubeshop.io>

* Improve github install (#272)

* update token rule

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* update detoken

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* update detoken

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Tweaks

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Fix atlantis and argocd

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Fix vault bootstrap

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Fix kubeconfig missing #268

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Unify install of metaphor #275 (#276)

* Unify install of metaphor #275

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Add branch support for metaphor

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Add space

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* feat: add unit test base (#274)

* feat: add unit test base

Signed-off-by: Jessica Marinho <jessica@kubeshop.io>
Co-authored-by: Jessica Marinho <jessica@kubeshop.io>

* Synch main v190 (#282)

* Update config.go (#224)

* update libs versions

Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>

* check if m1 and download arm64 supported version

Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>

* Allow templates to be version controlled by tags -  #227 (#231)

* Solve #227

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Add support to fallback logic

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Add support to fallback logic

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Add support to fallback logic

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Solve #233 (#234) - Adds cli version to telemetry

Adds cli version to telemetry

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* feat: add kubefirst config auto push to the user state store bucket

Signed-off-by: João Vanzuita <joao@kubeshop.io>

* change func to return bool if liveness test fail or not

Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>

* handling the value returned by func and panic if this is false

Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>

* fix: state pull when there is no kubefirst config file #218

Signed-off-by: João Vanzuita <joao@kubeshop.io>

* chore: update logic

Signed-off-by: João Vanzuita <joao@kubeshop.io>

* docker image to run kubefirst bin inside container  (#250)

Bump to release 1.8.6

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
Co-authored-by: 6za <53096417+6za@users.noreply.github.com>

* fix: add missing cmd entry for docker compose

Signed-off-by: João Vanzuita <joao@kubeshop.io>

* feat: add docker compose for developers

Signed-off-by: João Vanzuita <joao@kubeshop.io>

* Update docker-compose.yaml

* chore: update docker compose workdir

Signed-off-by: João Vanzuita <joao@kubeshop.io>

* chore: fix typo on installation screen

Signed-off-by: João Vanzuita <joao@kubeshop.io>

* synch with main

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Fix bucket cleaning logic

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
Signed-off-by: João Vanzuita <joao@kubeshop.io>
Co-authored-by: John Dietz <john@kubefirst.com>
Co-authored-by: Thiago Pagotto <pagottoo@gmail.com>
Co-authored-by: João Vanzuita <joao@kubeshop.io>

* chore: fix unit test

Signed-off-by: João Vanzuita <joao@kubeshop.io>

* chore: argocd command clean up (#285)

Signed-off-by: João Vanzuita <joao@kubeshop.io>

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>
Signed-off-by: João Vanzuita <joao@kubeshop.io>
Signed-off-by: Jessica Marinho <jessica@kubeshop.io>
Co-authored-by: Thiago Pagotto <pagottoo@gmail.com>
Co-authored-by: John Dietz <john@kubefirst.com>
Co-authored-by: João Vanzuita <joao@kubeshop.io>
Co-authored-by: Jessica Marinho <jessica@kubeshop.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@converge