Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make telemetry opt-out #140

Merged
merged 4 commits into from
Jul 20, 2022
Merged

Make telemetry opt-out #140

merged 4 commits into from
Jul 20, 2022

Conversation

6za
Copy link
Contributor

@6za 6za commented Jul 20, 2022

Allow telemetry to be disabled by user choice.

Signed-off-by: 6za 53096417+6za@users.noreply.github.com

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
pagottoo
pagottoo previously approved these changes Jul 20, 2022
@converge
Copy link
Contributor

it would be better to use the dry run flag to decide to send/or not telemetry data

send telemetry data only when dry-run flag is off

then we dont need extra flags/code

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
@6za
Copy link
Contributor Author

6za commented Jul 20, 2022

  • Dry-run is not a real execution.
  • Telemetry and Dry-run are not related, it just don't change anything outside, it is just a general run test without real action.

@6za
Copy link
Contributor Author

6za commented Jul 20, 2022

Sample init:

go run . init --admin-email johndoe@somewhere.io --cloud aws --hosted-zone-name somewhere.io --region us-east-1  --disable-telemetry

Logs will show:

LOG: 2022/07/20 12:23:28.096536 /home/developer/app/cmd/init.go:42: Telemetry Disabled

Sample on create:

go run . cluster create  --disable-telemetry

image

@converge
Copy link
Contributor

  • Telemetry and Dry-run are not related, it just don't change anything outside, it is just a general run test without real action.

why do we want to have a real run without telemetry?

@6za
Copy link
Contributor Author

6za commented Jul 20, 2022

Some users may not like to send telemetry for privacy concerns.
I am just following a request in channel to have a way to opt-out. Dry-run already opt-out by default to avoid mess with the collected data.

cmd/init.go Outdated Show resolved Hide resolved
cmd/root.go Show resolved Hide resolved
Signed-off-by: João Vanzuita <joao@kubeshop.io>
@6za
Copy link
Contributor Author

6za commented Jul 20, 2022

Updated sample:

developer@6c3b5f506205:~/app$ go run . cluster create --dry-run=true  --use-telemetry=true
Init actions: 4 expected tasks ...

LOG: 2022/07/20 20:16:14.601942 /home/developer/app/cmd/init.go:229: init started
Logging at: /home/developer/app/logs/log_1658348174.log
LOG: 2022/07/20 20:16:14.602344 /home/developer/app/pkg/helpers.go:132: Using config file: /home/developer/.kubefirst
-----------


  ----------------------------------------------------------------------
  Info summary:
  ----------------------------------------------------------------------

  Operational System: linux
  Architecture: amd64
  Go Lang version: vgo1.17.11
  Kubefirst config file: /home/developer/.kubefirst
  Kubefirst config folder: /home/developer/.k1
  Kubectl path: /home/developer/.k1/tools/kubectl
  Terraform path: /home/developer/.k1/tools/terraform
  Kubeconfig path: /home/developer/.k1/gitops/terraform/base/kubeconfig



Process Parameters            ... done! [1 in 1.004s]
- Creating K8S Cluster
- Created Softserve
Prepare Temporary Repo        ... 50.0% [##############..............] [2 in 2.69109s; ~ETA: 3s]
^Csignal: interrupt
developer@6c3b5f506205:~/app$ go run . cluster create --dry-run=true  --use-telemetry=false
Init actions: 4 expected tasks ...

LOG: 2022/07/20 20:16:25.293513 /home/developer/app/cmd/init.go:229: init started
Logging at: /home/developer/app/logs/log_1658348185.log
LOG: 2022/07/20 20:16:25.294123 /home/developer/app/pkg/helpers.go:132: Using config file: /home/developer/.kubefirst
-----------


  ----------------------------------------------------------------------
  Info summary:
  ----------------------------------------------------------------------

  Operational System: linux
  Architecture: amd64
  Go Lang version: vgo1.17.11
  Kubefirst config file: /home/developer/.kubefirst
  Kubefirst config folder: /home/developer/.k1
  Kubectl path: /home/developer/.k1/tools/kubectl
  Terraform path: /home/developer/.k1/tools/terraform
  Kubeconfig path: /home/developer/.k1/gitops/terraform/base/kubeconfig



Process Parameters            ... done! [1 in 1.003s]
- Telemetry Disabled
- Creating K8S Cluster
- Created Softserve
- Waiting Softserve
Prepare Temporary Repo        ... 75.0% [#####################.......] [3 in 3.190274s]

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
@johndietz johndietz merged commit 8a10689 into main Jul 20, 2022
@johndietz johndietz deleted the telemetry_opt_out branch July 20, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants