Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArgoCD Sync retry feature #142

Merged
merged 2 commits into from
Jul 21, 2022
Merged

ArgoCD Sync retry feature #142

merged 2 commits into from
Jul 21, 2022

Conversation

converge
Copy link
Contributor

  • add ArgoCD retry feature, it will retry to sync the application 10 times, with 6 seconds sleep each try

João Vanzuita added 2 commits July 21, 2022 17:33
feat: argocd sync retry feature
7eb1c87 
Signed-off-by: João Vanzuita <joao@kubeshop.io>
chore: clean up
b2ab5f1 
Signed-off-by: João Vanzuita <joao@kubeshop.io>
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 21, 2022
View reviewed changes
cmd/create.go
}

if !argoCDIsReady {
log.Println("unable to sync ArgoCD application, continuing...")

Check failure

Code scanning / CodeQL

Disabled TLS certificate check

InsecureSkipVerify should not be used in production code.
@converge converge merged commit 2b01c13 into main Jul 21, 2022
@converge converge deleted the update_argocd_calls branch July 21, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johndietz johndietz johndietz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@converge @johndietz