Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry certs logic #149

Merged
merged 4 commits into from
Jul 25, 2022
Merged

Retry certs logic #149

merged 4 commits into from
Jul 25, 2022

Conversation

6za
Copy link
Contributor

@6za 6za commented Jul 22, 2022

Exploring ways to retry cert for HTTPS on ArgoCD

Signed-off-by: 6za 53096417+6za@users.noreply.github.com

6za added 2 commits July 22, 2022 18:41
@6za
Retry certs logic
16c12dc 
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
@6za
Improve s3 creation logic
b71dc59 
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
converge
converge previously approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@converge converge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the cmd, instead of log.Panic, we can use log.Println() ; return on most of the cases.

@6za
tweak break logic
096443f 
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
pagottoo
pagottoo previously approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@pagottoo pagottoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@6za
tweak loop
2c10928 
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
@6za 6za merged commit 9c35f58 into main Jul 25, 2022
@6za 6za deleted the tweaks_20220722_v2 branch July 25, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@converge converge converge approved these changes

@pagottoo pagottoo pagottoo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@6za @converge @pagottoo