Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put-tag-bucket-delete-on-clean #150

Merged
merged 7 commits into from
Jul 25, 2022
Merged

put-tag-bucket-delete-on-clean #150

merged 7 commits into from
Jul 25, 2022

Conversation

pagottoo
Copy link
Contributor

@pagottoo pagottoo commented Jul 25, 2022

With this PR we have 2 features:

  • Put tags on buckets (provisioned-by and cluster-name);
  • During clean command we have a new flag (--destroy-buckets) to remove buckets from cloud provisioned when init command was executed.
  • We ask from user to confirm the destroy operation answering a question, and introduce another flag (--destroy-confirm) to work together --destroy-buckets that skip the question (and can be used in automation scripts)

pagottoo added 5 commits July 22, 2022 09:19
Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>
Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>
Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>
Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>
Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>
@pagottoo pagottoo self-assigned this Jul 25, 2022
cmd/clean.go Outdated Show resolved Hide resolved
cmd/clean.go Show resolved Hide resolved
Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>
6za
6za previously approved these changes Jul 25, 2022
Signed-off-by: Thiago Pagotto <pagottoo@gmail.com>
@pagottoo pagottoo merged commit a1d4d6f into main Jul 25, 2022
@pagottoo pagottoo deleted the feat-del-s3-on-clean-cmd branch July 25, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants