Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass CF_ORIGIN_CA_ISSUER_API_TOKEN to API #2347

Merged
merged 1 commit into from
Dec 13, 2024
Merged

fix: pass CF_ORIGIN_CA_ISSUER_API_TOKEN to API #2347

merged 1 commit into from
Dec 13, 2024

Conversation

muse-sisay
Copy link
Contributor

Description

pass CF_ORIGIN_CA_ISSUER_API_TOKEN env to API.

Related Issue(s)

Not able to use Cloudflare origin issuer when CF_ORIGIN_CA_ISSUER_API_TOKEN is set.

How to test

Add following lines to print cloudflare auth after CreateMgmtCluster func signature in internal/provisio/provision.go

	log.Printf("got cluster record. Value is")
	jclusterRecord, err := json.Marshal(clusterRecord.CloudflareAuth)
	if err != nil {
		return fmt.Errorf("Unable to conver cluster record tojson")
	}
	log.Print(string(jclusterRecord))
	os.Exit(1)

@linear Linear
Copy link

linear bot commented Dec 13, 2024

KRA-75 add originissuer resource to metaphor deployment

@muse-sisay muse-sisay merged commit 2a795f1 into main Dec 13, 2024
8 checks passed
@muse-sisay muse-sisay deleted the KRA-75 branch December 13, 2024 17:13
jokestax pushed a commit that referenced this pull request Jan 6, 2025
@muse-sisay @jokestax
fix: pass CF_ORIGIN_CA_ISSUER_API_TOKEN to API (#2347)
9b0b002
jokestax added a commit that referenced this pull request Jan 6, 2025
@jokestax @nathan-nicholson
@patrickdappollonio @konstruct-bot @mrsimonemms @fharper @muse-sisay
feat: add bottlerocket ami types (#2352)
dcb3fe8 
* add validation for aws ami type

* fix lint

* dependency for bottlerocket

* update api

* fix lint

* resolve validate credentials

* add test cases

* move up the logger

* more tests

* fix lint

* fix suggestions

* fix tests

* fix suggestion

* use slices

* fix print stmt

* delete duplicate

* fix lint

* fix print stmt

* fix spelling

* fix tests

* chore: make the mock function signature match the interface

Signed-off-by: nathan-nicholson <nathan@konstruct.io>

* chore: fix the ValidateCredentials test to use ErrorContains

Signed-off-by: nathan-nicholson <nathan@konstruct.io>

* chore: update ssm mock to use dynamic def of GetParameters

Signed-off-by: nathan-nicholson <nathan@konstruct.io>

* chore: more test refactoring

Signed-off-by: nathan-nicholson <nathan@konstruct.io>

* chore: remove unused attributes

Signed-off-by: nathan-nicholson <nathan@konstruct.io>

* chore: remove commented out code

Signed-off-by: nathan-nicholson <nathan@konstruct.io>

* fix: update paginator mock to be more flexible

Signed-off-by: nathan-nicholson <nathan@konstruct.io>

* Reduce test complexity.

* Apply suggestions from code review

Co-authored-by: Patrick D'appollonio <930925+patrickdappollonio@users.noreply.github.com>

* set next macro chart for kubefirst - 2.7.8-rc6

* set next macro chart for kubefirst - 2.7.8-rc7

* docs: add azure to the readme (#2343)

* chore: remove unused GitHub Workflow for devrel (#2346)

* fix: delete kubefirst file when doing kubefirst reset - KRA-73 (#2344)

---------

Signed-off-by: nathan-nicholson <nathan@konstruct.io>

* set next macro chart for kubefirst - 2.7.8-rc8

* set next macro chart for kubefirst - 2.7.8-rc9

* set next macro chart for kubefirst - 2.7.8-rc10

* set next macro chart for kubefirst - 2.7.9-rc1

* set next macro chart for kubefirst - 2.7.9-rc2

* set next macro chart for kubefirst - 2.7.9-rc3

* set next macro chart for kubefirst - 2.7.9-rc4

* set next macro chart for kubefirst - 2.7.9

* fix: pass CF_ORIGIN_CA_ISSUER_API_TOKEN to API (#2347)

* set next macro chart for kubefirst - 2.7.10-rc1

* remove vultr and google out of beta (#2351)

* set next macro chart for kubefirst - 2.7.10-rc2

* set next macro chart for kubefirst - 2.7.10-rc3

* fix(azure): change GCP ref in CLI docs to Azure (#2353)

* set next macro chart for kubefirst - 2.7.10-rc4

* fix: go indent

* fix: fumpt

---------

Signed-off-by: nathan-nicholson <nathan@konstruct.io>
Co-authored-by: nathan-nicholson <nathan@konstruct.io>
Co-authored-by: Patrick D'appollonio <930925+patrickdappollonio@users.noreply.github.com>
Co-authored-by: konstruct-bot <konstruct-bot@konstruct.io>
Co-authored-by: Simon Emms <simon@simonemms.com>
Co-authored-by: Frédéric Harper <hi@fred.dev>
Co-authored-by: Muse Mulatu <48902323+muse-sisay@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarededwards jarededwards jarededwards approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muse-sisay @jarededwards