Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing error handler #574

Merged
merged 5 commits into from
Oct 18, 2022
Merged

fix: add missing error handler #574

merged 5 commits into from
Oct 18, 2022

Conversation

converge
Copy link
Contributor

Signed-off-by: João Vanzuita joao@kubeshop.io

João Vanzuita added 5 commits October 18, 2022 07:56
Signed-off-by: João Vanzuita <joao@kubeshop.io>
Signed-off-by: João Vanzuita <joao@kubeshop.io>
Signed-off-by: João Vanzuita <joao@kubeshop.io>
Signed-off-by: João Vanzuita <joao@kubeshop.io>
Signed-off-by: João Vanzuita <joao@kubeshop.io>
Copy link
Contributor

@6za 6za left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@converge converge merged commit 36a48ea into main Oct 18, 2022
@converge converge deleted the add_missing_error_handler branch October 18, 2022 11:37
6za added a commit that referenced this pull request Oct 18, 2022
* fix: add missing error handler (#574)

* fix: add missing error handler for telemetry

Signed-off-by: João Vanzuita <joao@kubeshop.io>

* Tweaks and updates

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Add local coorections

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Add local coorections

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

Signed-off-by: João Vanzuita <joao@kubeshop.io>
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
Co-authored-by: João Paulo Vanzuita <joao@kubeshop.io>
jarededwards added a commit that referenced this pull request Oct 18, 2022
* move destroy command to cluster

* initial commit for destroy for local

* fix file rename

* stable install and destroy up to argocd

* fix type in function name

* fix more argo names

* minor refactors and more recovery points

* minor cleanup and rm terraform lock file

* split helm repo add and install to reduce log output when errors occur

* refactor argocd sync and remove duplicat pf that caused issue

* remove duplicate port forward causing issues

* minor adjustment

* 501 localhost four (#576)

* fix: add missing error handler (#574)

* fix: add missing error handler for telemetry

Signed-off-by: João Vanzuita <joao@kubeshop.io>

* Tweaks and updates

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Add local coorections

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Add local coorections

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

Signed-off-by: João Vanzuita <joao@kubeshop.io>
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
Co-authored-by: João Paulo Vanzuita <joao@kubeshop.io>

Signed-off-by: João Vanzuita <joao@kubeshop.io>
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
Co-authored-by: Cesar Filho <53096417+6za@users.noreply.github.com>
Co-authored-by: João Paulo Vanzuita <joao@kubeshop.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants