-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing error handler #574
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: João Vanzuita <joao@kubeshop.io>
Signed-off-by: João Vanzuita <joao@kubeshop.io>
Signed-off-by: João Vanzuita <joao@kubeshop.io>
Signed-off-by: João Vanzuita <joao@kubeshop.io>
Signed-off-by: João Vanzuita <joao@kubeshop.io>
6za
approved these changes
Oct 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
6za
added a commit
that referenced
this pull request
Oct 18, 2022
* fix: add missing error handler (#574) * fix: add missing error handler for telemetry Signed-off-by: João Vanzuita <joao@kubeshop.io> * Tweaks and updates Signed-off-by: 6za <53096417+6za@users.noreply.github.com> * Add local coorections Signed-off-by: 6za <53096417+6za@users.noreply.github.com> * Add local coorections Signed-off-by: 6za <53096417+6za@users.noreply.github.com> Signed-off-by: João Vanzuita <joao@kubeshop.io> Signed-off-by: 6za <53096417+6za@users.noreply.github.com> Co-authored-by: João Paulo Vanzuita <joao@kubeshop.io>
jarededwards
added a commit
that referenced
this pull request
Oct 18, 2022
* move destroy command to cluster * initial commit for destroy for local * fix file rename * stable install and destroy up to argocd * fix type in function name * fix more argo names * minor refactors and more recovery points * minor cleanup and rm terraform lock file * split helm repo add and install to reduce log output when errors occur * refactor argocd sync and remove duplicat pf that caused issue * remove duplicate port forward causing issues * minor adjustment * 501 localhost four (#576) * fix: add missing error handler (#574) * fix: add missing error handler for telemetry Signed-off-by: João Vanzuita <joao@kubeshop.io> * Tweaks and updates Signed-off-by: 6za <53096417+6za@users.noreply.github.com> * Add local coorections Signed-off-by: 6za <53096417+6za@users.noreply.github.com> * Add local coorections Signed-off-by: 6za <53096417+6za@users.noreply.github.com> Signed-off-by: João Vanzuita <joao@kubeshop.io> Signed-off-by: 6za <53096417+6za@users.noreply.github.com> Co-authored-by: João Paulo Vanzuita <joao@kubeshop.io> Signed-off-by: João Vanzuita <joao@kubeshop.io> Signed-off-by: 6za <53096417+6za@users.noreply.github.com> Co-authored-by: Cesar Filho <53096417+6za@users.noreply.github.com> Co-authored-by: João Paulo Vanzuita <joao@kubeshop.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: João Vanzuita joao@kubeshop.io