Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement ngrok library #589

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Conversation

converge
Copy link
Contributor

Signed-off-by: João Vanzuita joao@kubeshop.io

Signed-off-by: João Vanzuita <joao@kubeshop.io>
@jarededwards
Copy link
Contributor

lgtm, going to merge this since its only going into my branch

@jarededwards jarededwards merged commit 45326ed into 501_localhost_4 Oct 19, 2022
@jarededwards jarededwards deleted the implement_ngrok_lib branch October 19, 2022 15:26
jarededwards added a commit that referenced this pull request Oct 19, 2022
* log cleanup, remove unused vars, debug files

* selective folder removal for local experience

* remove default aws region

* remove debug logging of files

* only call update for local if its local mode

* adjust envs for local execution

* re-order destroy k3d, add port-forward for minio

* missing flags from github, sidestepping for now

* remove bad fix for flag binding

* adds additional github config and write config

* missed github.user property

* remove panic, fix missing user property

* remove panic, fix missing user property

* remove hack for missing github properties

* fix await host function to return when status is 200

* fix TerraformClientPath constant

* fix exit code when using k3d

* missed tf client path

* open ngrok url for atlantis webook

* feat: implement ngrok library (#589)

Signed-off-by: João Vanzuita <joao@kubeshop.io>

Signed-off-by: João Vanzuita <joao@kubeshop.io>

* reorder import

* reorder import

* full execution complete

* ecr repos moved into github repos, cleanup

Signed-off-by: João Vanzuita <joao@kubeshop.io>
Co-authored-by: João Paulo Vanzuita <joao@kubeshop.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants