Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewire local #635

Merged
merged 3 commits into from
Nov 2, 2022
Merged

Rewire local #635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0f2305
refactor: move local to a single command
Nov 1, 2022
fb9c9a0
chore: wip
Nov 2, 2022
100b8a0
feat: split cobra functions
Nov 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ cluster provisioning process spinning up the services, and validates the livenes
// todo: wire it up in the architecture / files / folder

// update terraform s3 backend to internal k8s dns (s3/minio bucket)
err = pkg.ReplaceS3Backend()
err = pkg.ReplaceTerraformS3Backend()
if err != nil {
return err
}
Expand All @@ -280,7 +280,7 @@ cluster provisioning process spinning up the services, and validates the livenes
branchName := "update-s3-backend"
branchNameRef := plumbing.ReferenceName("refs/heads/" + branchName)

gitClient.UpdateLocalTFFilesAndPush(
gitClient.UpdateLocalTerraformFilesAndPush(
githubHost,
githubOwner,
localRepo,
Expand Down
4 changes: 4 additions & 0 deletions cmd/createUtils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import (
)

// todo: move it to internals/ArgoCD
// deprecated
func setArgocdCreds(dryRun bool) {
if dryRun {
log.Printf("[#99] Dry-run mode, setArgocdCreds skipped.")
Expand All @@ -43,6 +44,7 @@ func setArgocdCreds(dryRun bool) {
viper.WriteConfig()
}

// deprecated
func waitArgoCDToBeReady(dryRun bool) {
if dryRun {
log.Printf("[#99] Dry-run mode, waitArgoCDToBeReady skipped.")
Expand Down Expand Up @@ -76,6 +78,7 @@ func waitArgoCDToBeReady(dryRun bool) {
}
}

// deprecated
func waitVaultToBeRunning(dryRun bool) {
if dryRun {
log.Printf("[#99] Dry-run mode, waitVaultToBeRunning skipped.")
Expand Down Expand Up @@ -115,6 +118,7 @@ func waitVaultToBeRunning(dryRun bool) {
}
}

// deprecated
func loopUntilPodIsReady(dryRun bool) {
if dryRun {
log.Printf("[#99] Dry-run mode, loopUntilPodIsReady skipped.")
Expand Down
2 changes: 1 addition & 1 deletion cmd/local.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ func init() {

//Group Flags

rootCmd.AddCommand(localCmd)
//rootCmd.AddCommand(localCmd)
currentCommand := localCmd
//log.SetPrefix("LOG: ")
//log.SetFlags(log.Ldate | log.Lmicroseconds | log.Llongfile)
Expand Down
Loading