Add check tools and update outputs #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
|
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
converge
reviewed
Jul 4, 2022
| @@ -27,7 +28,7 @@ to quickly create a Cobra application.`, | |||
| // todo this needs to be removed when we are no longer in the starter account | |||
| os.Setenv("AWS_PROFILE", "starter") | |||
|
|
|||
| fmt.Println("\n\nTODO -- need to setup and argocd delete against registry and wait?\n\n") | |||
| log.Println("\n\nTODO -- need to setup and argocd delete against registry and wait?\n\n") | |||
There was a problem hiding this comment.
the line breaks won't be necessary with Println
| @@ -62,7 +63,7 @@ to quickly create a Cobra application.`, | |||
| tfInitGitlabCmd.Stderr = os.Stderr | |||
| err = tfInitGitlabCmd.Run() | |||
| if err != nil { | |||
| fmt.Println("failed to call terraform init gitlab: ", err) | |||
| log.Println("failed to call terraform init gitlab: ", err) | |||
There was a problem hiding this comment.
we could make a single call to reduce functions size, like:
log.Panicf("failed to call terraform init GitLab: %s", err)
| @@ -16,7 +17,7 @@ func setGlobals() { | |||
| tmphome, err := os.UserHomeDir() | |||
| home = tmphome | |||
| if(err != nil){ | |||
| fmt.Printf("Error Defining home - %s", err) | |||
| log.Printf("Error Defining home - %s", err) | |||
There was a problem hiding this comment.
we can do it later as well:
log.Panicf("...") instead of log + exit(1) , panic will clean up contexts, and close open http connections before exiting.
| viper.Set("create.softserve.create", true) | ||
| viper.WriteConfig() | ||
| log.Println("waiting for soft-serve installation to complete...") | ||
| time.Sleep(60 * time.Second) |
There was a problem hiding this comment.
it could be a good idea to add a todo: to remember to update this blocker later on
|
|
||
| err := os.Chdir(directory) | ||
| if err != nil { | ||
| log.Println("error changing dir") |
There was a problem hiding this comment.
should we log and exit in this case?
| execShellReturnStrings(terraformPath, fmt.Sprintf("%s", terraformAction), "-auto-approve") | ||
| keyOut, _, errKey := execShellReturnStrings(terraformPath, "output", "vault_unseal_kms_key") | ||
| if errKey != nil { | ||
| log.Println("failed to call tfOutputCmd.Run(): ", err) |
There was a problem hiding this comment.
should we log and exit in this case?
|
Updating on the next PR:#70 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some extra features to go-cli:
init, printinfoto logs and STDOUT.checktoolsto validate download binaries, for compatibility check.execShellReturnStringsSigned-off-by: 6za 53096417+6za@users.noreply.github.com