Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove local from cloud cli #689

Merged
merged 1 commit into from
Nov 9, 2022
Merged

remove local from cloud cli #689

merged 1 commit into from
Nov 9, 2022

Conversation

6za
Copy link
Contributor

@6za 6za commented Nov 9, 2022

Remove local references from CLOUD CLI

Signed-off-by: 6za 53096417+6za@users.noreply.github.com

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
Copy link
Contributor

@pagottoo pagottoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@6za
Copy link
Contributor Author

6za commented Nov 9, 2022

install worked as expected:
image

@6za
Copy link
Contributor Author

6za commented Nov 9, 2022

metaphor is still unfolding:
image

@6za 6za merged commit 0e5dc3b into move_auth_logic Nov 9, 2022
@6za 6za deleted the clean_init branch November 9, 2022 13:14
6za added a commit that referenced this pull request Nov 9, 2022
* feat: enable github token to be accepted via env. variable

Signed-off-by: João Vanzuita <joao@kubeshop.io>

* chore: clean up

Signed-off-by: João Vanzuita <joao@kubeshop.io>

* fix: add get github data (#680)

Signed-off-by: João Vanzuita <joao@kubeshop.io>

Signed-off-by: João Vanzuita <joao@kubeshop.io>

* Change reference to github token (#681)

Signed-off-by: Jessica Marinho <jessica@kubeshop.io>

Signed-off-by: Jessica Marinho <jessica@kubeshop.io>
Co-authored-by: Jessica Marinho <jessica@kubeshop.io>

* chore: clean up (#683)

Signed-off-by: João Vanzuita <joao@kubeshop.io>

Signed-off-by: João Vanzuita <joao@kubeshop.io>

* revert break of handoff (#684)

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* Fix 664 (#685)

* revert break of handoff

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* re-enable addon to local

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* chore: move get github user away from authenticate

Signed-off-by: João Vanzuita <joao@kubeshop.io>

* chore: clean up

Signed-off-by: João Vanzuita <joao@kubeshop.io>

* chore: remove github.org , add github.owner

Signed-off-by: João Vanzuita <joao@kubeshop.io>

* feat: ask for github token on github aws create

Signed-off-by: João Vanzuita <joao@kubeshop.io>

* chore: clean up

Signed-off-by: João Vanzuita <joao@kubeshop.io>

* remove local from cloud cli (#689)

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* feat: ask for github token on github aws init

Signed-off-by: João Vanzuita <joao@kubeshop.io>

* Set github owner with config file (#693)

Signed-off-by: Jessica Marinho <jessica@kubeshop.io>

Signed-off-by: Jessica Marinho <jessica@kubeshop.io>
Co-authored-by: Jessica Marinho <jessica@kubeshop.io>

Signed-off-by: João Vanzuita <joao@kubeshop.io>
Signed-off-by: Jessica Marinho <jessica@kubeshop.io>
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
Co-authored-by: Jéssica Marinho <jlmarinhocosta@gmail.com>
Co-authored-by: Jessica Marinho <jessica@kubeshop.io>
Co-authored-by: Cesar Filho <53096417+6za@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants