Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Include github validation on init #721

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Conversation

marinhojess
Copy link
Contributor

Signed-off-by: Jessica Marinho jessica@kubeshop.io

Kubefirst init is trying to get github user even if git-provider is gitlab. To fix thus, we've included validation before calling the github API to ensure the flavor is github.

Signed-off-by: Jessica Marinho <jessica@kubeshop.io>
@marinhojess marinhojess merged commit dc66ee1 into main Nov 14, 2022
@marinhojess marinhojess deleted the add-github-validation branch November 14, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants