chore: clean up

cmd/destroyLocalGithub.go

@@ -30,7 +30,6 @@ var destroyLocalGithubCmd = &cobra.Command{
 	Short: "A brief description of your command",
 	Long:  `TDB`,
 	RunE: func(cmd *cobra.Command, args []string) error {
-		fmt.Println("destroy-local-github called")
 		config := configs.ReadConfig()
 
 		destroyFlags, err := flagset.ProcessDestroyFlags(cmd)

cmd/local/local.go

@@ -100,7 +100,6 @@ func runLocal(cmd *cobra.Command, args []string) error {
 	// todo need to add go channel to control when ngrok should close
 	// and use context to handle closing the open goroutine/connection
 	go pkg.RunNgrok(context.TODO(), pkg.LocalAtlantisURL)
-	time.Sleep(5 * time.Second)
 
 	if !viper.GetBool("kubefirst.done") {
 		if viper.GetString("gitprovider") == "github" {
@@ -276,9 +275,6 @@ func runLocal(cmd *cobra.Command, args []string) error {
 
 	k8s.LoopUntilPodIsReady(dryRun)
 
-	// todo: can I remove it?
-	time.Sleep(20 * time.Second)
-
 	// configure vault with terraform
 	executionControl = viper.GetBool("terraform.vault.apply.complete")
 	if !executionControl {

internal/argocd/argocd.go

@@ -319,21 +319,20 @@ func ApplyRegistry(dryRun bool) error {
 func ApplyRegistryLocal(dryRun bool) error {
 	config := configs.ReadConfig()
 
-	if viper.GetBool("argocd.registry.applied") {
+	if viper.GetBool("argocd.registry.applied") || dryRun {
 		log.Println("skipped ApplyRegistryLocal - ")
 		return nil
 	}
 
-	if !dryRun {
-		_, _, err := pkg.ExecShellReturnStrings(config.KubectlClientPath, "--kubeconfig", config.KubeConfigPath, "-n", "argocd", "apply", "-f", fmt.Sprintf("%s/gitops/registry.yaml", config.K1FolderPath))
-		if err != nil {
-			log.Printf("failed to execute localhost kubectl apply of registry-base: %s", err)
-			return err
-		}
-		time.Sleep(45 * time.Second)
-		viper.Set("argocd.registry.applied", true)
-		viper.WriteConfig()
+	_, _, err := pkg.ExecShellReturnStrings(config.KubectlClientPath, "--kubeconfig", config.KubeConfigPath, "-n", "argocd", "apply", "-f", fmt.Sprintf("%s/gitops/registry.yaml", config.K1FolderPath))
+	if err != nil {
+		log.Printf("failed to execute localhost kubectl apply of registry-base: %s", err)
+		return err
 	}
+	time.Sleep(45 * time.Second)
+	viper.Set("argocd.registry.applied", true)
+	viper.WriteConfig()
+
 	return nil
 }
 

pkg/helpers.go

@@ -574,7 +574,7 @@ func UpdateTerraformS3BackendForLocalhostAddress() error {
 			"http://minio.minio.svc.cluster.local:9000",
 			MinioURL,
 		); err != nil {
-			return err
+			log.Println(err)
 		}
 	}