Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorthand WebSocketTransport factories with serializers #61

Conversation

yurii-prykhodko-solid
Copy link
Contributor

Adds shorthand constructors to WebSocketTransport classes, so attaching a serializer to one is now a bit simpler.
The user code will be slightly more concise also.

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% 🎉

Comparison is base (0019a29) 90.13% compared to head (e1d01ba) 90.15%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
+ Coverage   90.13%   90.15%   +0.02%     
==========================================
  Files          44       44              
  Lines        2819     2825       +6     
==========================================
+ Hits         2541     2547       +6     
  Misses        278      278              
Files Changed Coverage Δ
...rc/transport/websocket/websocket_transport_io.dart 83.05% <100.00%> (+1.91%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 I think it is a good addition: less boilerplate code and cleaner look :)

Copy link
Owner

@konsultaner konsultaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it!

@konsultaner konsultaner merged commit debcf5c into konsultaner:master Sep 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants