Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tag for vvar and vdso regions, this will stop MADV_DONTNEED #1768

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sv641
Copy link
Contributor

@sv641 sv641 commented Jul 18, 2023

vvar and vdso are always needed.

@paulpopelka
Copy link
Contributor

This change is reverting the following commit:

commit e795afa
Author: paulpopelka paulp@kontain.app
Date: Thu Mar 2 12:07:39 2023 -0800

Fix km to allow gdb to use the symbols in the vdso pages (#1743)

Don't assign a filename to the vvar and vdso regions in the km memory busy map.
km was assigning the non-filenames [vvar] and [vdso] to the vdso regions
which apparently prevented gdb from checking to see if they were the
vdso area.

A quick way to test is run gdb on a payload coredump and then
run the "disassem gettimeofday" command.
You will see symbols like __vdso_gettimeofday in the output which tells
you gdb was able to access the symbols stored in the vdso pages.

Is there some way to allow both "needs" to be met?

@sv641
Copy link
Contributor Author

sv641 commented Jul 18, 2023

It is a longer fix. I will do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants