Add configuration change validations #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
January 25, 2019 08:51
kke
changed the title
jakolehm
reviewed
Jan 30, 2019
lib/pharos/config.rb
Outdated
|
|
||
| # @example deep get network provider | ||
| # config.deep_get("network.provider") | ||
| # @param key [String] a dot separated key, such as network.provider |
| yield config_key, old_value, new_value | ||
| end | ||
|
|
||
| def previous_config |
There was a problem hiding this comment.
It's only used in addon_manager in addition to this phase.
jakolehm
reviewed
Jan 30, 2019
lib/pharos/config.rb
Outdated
| # config.deep_get("network.provider") | ||
| # @param key [String] a dot separated key, such as network.provider | ||
| # @return [Object,NilClass] nil when any part of the chain is unreachable | ||
| def deep_get(key) |
There was a problem hiding this comment.
Probably should use Pharos::CoreExt::DeepKeys?
There was a problem hiding this comment.
This one doesn't need to hashify in the middle. Interestingly, something like config.deep_get("hosts.first.address") works with this.
There was a problem hiding this comment.
Is one .to_h that bad? It would remove duplicate code.
There was a problem hiding this comment.
I threw away the DeepKeys refinement thing and replaced it with HashDiff and renamed config.deep_get to config.dig which acts like hash.dig: config.dig(:network, :provider).
kke
force-pushed
the
feature/config_change_validation
branch
from
b860ce5 to
cf04d08
Compare
jakolehm
reviewed
Jan 30, 2019
lib/pharos/autoload.rb
Outdated
| @@ -47,6 +47,7 @@ module CommandOptions | |||
| module CoreExt | |||
| autoload :IPAddrLoopback, 'pharos/core-ext/ip_addr_loopback' | |||
| autoload :DeepTransformKeys, 'pharos/core-ext/deep_transform_keys' | |||
| autoload :DeepKeys, 'pharos/core-ext/deep_keys' | |||
jakolehm
reviewed
Jan 31, 2019
lib/pharos/autoload.rb
Outdated
| @@ -47,6 +47,7 @@ module CommandOptions | |||
| module CoreExt | |||
| autoload :IPAddrLoopback, 'pharos/core-ext/ip_addr_loopback' | |||
| autoload :DeepTransformKeys, 'pharos/core-ext/deep_transform_keys' | |||
| autoload :DeepKeys, 'pharos/core-ext/deep_keys' | |||
There was a problem hiding this comment.
Suggested change
| autoload :DeepKeys, 'pharos/core-ext/deep_keys' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #997
Here's the mechanism
For addons added a hook:
It can also be defined with only 1 param:
Or 3:
For phases / general config changes, made the cluster_manager load previous config earlier and run
ValidateConfigurationChangesphase if a working master was found duringGatherFacts.It appears to work: