Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log phase completed message #1008

Merged
merged 2 commits into from
Jan 30, 2019
Merged

Log phase completed message #1008

merged 2 commits into from
Jan 30, 2019

Conversation

jakolehm
Copy link
Contributor

IMO gives better feedback to users.

Example:

    [pharos-worker-0] Configuring package repositories ...
    [pharos-master-2] Configuring package repositories ...
    [pharos-master-1] Configuring netfilter ...
    [pharos-master-0] Configuring netfilter ...
    [pharos-worker-1] Configuring package repositories ...
    [pharos-master-2] Configuring netfilter ...
    [pharos-worker-0] Configuring netfilter ...
    [pharos-master-1] Configuring container runtime (cri-o) packages ...
    [pharos-master-0] Configuring container runtime (cri-o) packages ...
    [pharos-master-2] Configuring container runtime (cri-o) packages ...
    [pharos-worker-0] Configuring container runtime (cri-o) packages ...
    [pharos-worker-1] Configuring netfilter ...
    [pharos-worker-1] Configuring container runtime (cri-o) packages ...
    [pharos-worker-2] Configuring package repositories ...
    [pharos-worker-2] Configuring netfilter ...
    [pharos-master-1] Completed phase in 22.30s
    [pharos-master-2] Completed phase in 24.68s
    [pharos-worker-2] Configuring container runtime (cri-o) packages ...
    [pharos-worker-1] Completed phase in 25.38s
    [pharos-worker-0] Completed phase in 25.38s
    [pharos-master-0] Completed phase in 25.44s
    [pharos-worker-2] Completed phase in 34.95s

@jakolehm jakolehm added the enhancement New feature or request label Jan 25, 2019
@jakolehm jakolehm requested review from jnummelin and kke January 29, 2019 08:13
kke
kke reviewed Jan 29, 2019
View reviewed changes
lib/pharos/phase_manager.rb Outdated Show resolved Hide resolved
@jnummelin
Copy link
Contributor

To me the output looks bit weird. There's random Completed phase in 34.95s row, but I've got no idea to which phase they are referring to :/

@jakolehm
Copy link
Contributor Author

To me the output looks bit weird. There's random Completed phase in 34.95s row, but I've got no idea to which phase they are referring to :/

Example output is missing that information.. but all of those lines are under "phase heading".

@jakolehm jakolehm added this to the 2.2.0 milestone Jan 29, 2019
@kke @jakolehm
Update lib/pharos/phase_manager.rb
9a23cce 
Co-Authored-By: jakolehm <jari.kolehmainen@gmail.com>
@jakolehm jakolehm merged commit 3728384 into master Jan 30, 2019
@jakolehm jakolehm deleted the feature/log-phase-completed branch January 30, 2019 09:09
This was referenced Feb 1, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kke kke kke left review comments

@jnummelin jnummelin jnummelin approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jakolehm @jnummelin @kke