Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set NO_MASQ_LOCAL for weave #1027

Merged
merged 1 commit into from
Jan 30, 2019
Merged

Conversation

jnummelin
Copy link
Contributor

@jnummelin jnummelin commented Jan 30, 2019

Setting this up in the config:

network:
  weave:
    no_masq_local: true
$ for node in $NODES; do curl -s $node:$NODEPORT | grep -i client_address; done
client_address=10.38.0.0
client_address=10.32.0.1
client_address=10.44.0.0

$ kubectl patch svc nodeport -p '{"spec":{"externalTrafficPolicy":"Local"}}'
service/nodeport patched

$ for node in $NODES; do curl --connect-timeout 1 -s $node:$NODEPORT | grep -i client_address; done
client_address=91.153.x.y

^ the reported address is my actual address :)

Docs PR: kontena/pharos-docs#147

fixes #1010

@jnummelin jnummelin added this to the 2.2.0 milestone Jan 30, 2019
@jnummelin
Copy link
Contributor Author

The option defaults to false to preserve the existing behaviour in existing clusters. Putting it on by default might break network policies etc. for existing clusters.

Copy link
Contributor

@jakolehm jakolehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakolehm jakolehm merged commit 3f6281e into master Jan 30, 2019
@jakolehm jakolehm deleted the fix/weave-no-masq-local branch January 30, 2019 11:14
This was referenced Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SourceIP preservation with weave-net not possible
2 participants