Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop phase master: parameter #1028

Merged
merged 4 commits into from
Jan 30, 2019
Merged

Drop phase master: parameter #1028

merged 4 commits into from
Jan 30, 2019

Conversation

kke
Copy link
Contributor

@kke kke commented Jan 30, 2019 •
edited
Loading

None of the phases except configure_host on non-oss use @master and there's no attr_reader so it must be unused.

Changed the configure_host to use master_ssh and @config.master_host instead of @master.

Also replaced the [master_hosts.first] repetition with master_only preassigned array because this PR touches those lines anyway.

@kke kke added the chore label Jan 30, 2019
@kke kke requested a review from jakolehm January 30, 2019 11:01
@jakolehm jakolehm added this to the 2.2.0 milestone Jan 30, 2019
@jakolehm jakolehm merged commit e8d243c into master Jan 30, 2019
@jakolehm jakolehm deleted the chore/drop_master_param branch January 30, 2019 11:20
This was referenced Feb 1, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakolehm jakolehm jakolehm approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kke @jakolehm