Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip incomplete-elements errors when publishing variants #43

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

JiriLojda
Copy link
Member

  • it is possible to get into this state quite easily (e.g. adding restrictions to a content type after some variants of this type have been published) so failing on this is rather obtrusive

Motivation

Which issue does this fix? Fixes #issue number

If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@JiriLojda JiriLojda requested a review from a team as a code owner May 9, 2024 17:32
@IvanKiral IvanKiral force-pushed the skip_incomplete_element_errors_on_publish branch from 29f92aa to a8a1fea Compare August 28, 2024 06:36
@JiriLojda JiriLojda force-pushed the skip_incomplete_element_errors_on_publish branch from a8a1fea to 6917c9e Compare August 28, 2024 13:49
JiriLojda and others added 2 commits August 28, 2024 15:51
- it is possible to get into this state quite easily (e.g. adding restrictions to a content type after some variants of this type have been published) so failing on this is rather obtrusive
@JiriLojda JiriLojda force-pushed the skip_incomplete_element_errors_on_publish branch from 6917c9e to 870ab6f Compare August 28, 2024 13:51
@JiriLojda JiriLojda merged commit 8c23f62 into main Aug 28, 2024
3 checks passed
@JiriLojda JiriLojda deleted the skip_incomplete_element_errors_on_publish branch August 28, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants